Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add k8s_api_verify_ssl config #801

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Add k8s_api_verify_ssl config #801

merged 3 commits into from
Nov 8, 2023

Conversation

devenami
Copy link
Contributor

When the k8s cluster uses self signed certificates, Python may not be able to verify the validity of the root certificate, resulting in client calls failing. We can modify by verify_ssl parameter skip certificate validation。

Fixes #799

@welcome
Copy link

welcome bot commented Oct 23, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

yuvipanda
yuvipanda requested changes Nov 6, 2023
View reviewed changes
kubespawner/proxy.py Outdated Show resolved Hide resolved
@devenami devenami requested a review from yuvipanda November 7, 2023 03:13
yuvipanda
yuvipanda reviewed Nov 7, 2023
View reviewed changes
kubespawner/proxy.py Outdated Show resolved Hide resolved
yuvipanda
yuvipanda reviewed Nov 7, 2023
View reviewed changes
kubespawner/spawner.py Outdated Show resolved Hide resolved
@yuvipanda
Copy link
Collaborator

@devenami I can't seem to accept these changes - once you accept them, I'm happy to merge.

Thank you for your contributions!

@devenami
Copy link
Contributor Author

devenami commented Nov 8, 2023

@devenami I can't seem to accept these changes - once you accept them, I'm happy to merge.

Thank you for your contributions!

@yuvipanda thanks for your code review and suggestions, i accept your suggestions and pushed a new commit.

@devenami devenami requested a review from yuvipanda November 8, 2023 06:08
@yuvipanda yuvipanda merged commit a227db3 into jupyterhub:main Nov 8, 2023
7 checks passed
@welcome Welcome
Copy link

welcome bot commented Nov 8, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@yuvipanda
Copy link
Collaborator

Thanks, @devenami

@consideRatio consideRatio changed the title enable k8s client verify_ssl param Add k8s_api_verify_ssl config Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda Awaiting requested review from yuvipanda

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

certificate verify failed: self signed certificate
3 participants
@devenami @yuvipanda @consideRatio